Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to run a testNg/testStreaming test on its own #5338

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add the ability to run a testNg/testStreaming test on its own #5338

merged 4 commits into from
Jan 17, 2024

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Dec 8, 2023

Motivation:

Currently, testNg is run after shadedTest is run when the check command is invoked.
However, even if there are updates to the source code, testNg won't attempt to recompile the source code.
This can be easily reproduced by modifying a testNg class, and trying to run ./gradlew testNg.

This is because testNg currently depends on the classpath of shadedTest. As long as shadedTest isn't invoked, the shadedTest.classpath won't be updated.

Modifications:

  • Since copyShadedTestClasses declares the test classpath as an input, it is safe to rely on copyShadedTestClasses (just like shadedTest does). Modified testNg, testStreaming to depend on copyShadedTestClasses instead.
  • Removed the finalizedBy dependency since it doesn't make sense to have a dependency between shadedTest and testNg/testStreaming.

Result:

  • We can run ./gradlew testNg and receive results correctly

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

🔍 Build Scan® (commit: e803532)

Job name Status Build Scan®
build-windows-latest-jdk-19 ✅ https://ge.armeria.dev/s/ime7ejh3ykoga
build-self-hosted-jdk-8 ✅ https://ge.armeria.dev/s/bqwy6avs2sksw
build-self-hosted-jdk-19-snapshot-blockhound ✅ https://ge.armeria.dev/s/2d3oi2ggljgde
build-self-hosted-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/jfneky65eyul6
build-self-hosted-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/zsjqdtp36jj74
build-self-hosted-jdk-17-leak ✅ https://ge.armeria.dev/s/z3kkab3i6tg2w
build-self-hosted-jdk-11 ❌ (failure) https://ge.armeria.dev/s/tgnwjwhj7wlbc
build-macos-12-jdk-19 ✅ https://ge.armeria.dev/s/maxbt2ifdpm6y

@jrhee17
Revert "add failing tests"
e6890e3 
This reverts commit 48ee58e.
@jrhee17 jrhee17 marked this pull request as ready for review December 8, 2023 12:04
@jrhee17 jrhee17 added the cleanup label Dec 8, 2023
@jrhee17 jrhee17 changed the title Add the ability to run a testNg/testStreaming test on it's own Add the ability to run a testNg/testStreaming test on its own Dec 8, 2023
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30c9718) 0.00% compared to head (e803532) 73.68%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5338       +/-   ##
===========================================
+ Coverage        0   73.68%   +73.68%     
- Complexity      0    20106    +20106     
===========================================
  Files           0     1741     +1741     
  Lines           0    74353    +74353     
  Branches        0     9481     +9481     
===========================================
+ Hits            0    54790    +54790     
- Misses          0    15029    +15029     
- Partials        0     4534     +4534

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

minwoox
minwoox approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@jrhee17 jrhee17 merged commit c4c6b3d into line:main Jan 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@trustin trustin trustin approved these changes

@ikhoon ikhoon Awaiting requested review from ikhoon ikhoon is a code owner

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhee17 @trustin @minwoox