Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API usages #5249

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove deprecated API usages #5249

merged 1 commit into from
Oct 19, 2023

Conversation

minwoox
Copy link
Contributor

@minwoox minwoox commented Oct 19, 2023

No description provided.

@minwoox
Copy link
Contributor Author

minwoox commented Oct 19, 2023

I couldn't remove all the usages because it took more time than I thought. Let me continue to working on this later when I have some time. 😉

ikhoon
ikhoon approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️🙇‍♂️

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (96f496d) 74.07% compared to head (37e6fad) 74.04%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5249      +/-   ##
============================================
- Coverage     74.07%   74.04%   -0.04%     
+ Complexity    20012    19999      -13     
============================================
  Files          1718     1718              
  Lines         73699    73679      -20     
  Branches       9383     9383              
============================================
- Hits          54596    54555      -41     
- Misses        14662    14687      +25     
+ Partials       4441     4437       -4
Files Coverage Δ
...orp/armeria/client/AbstractDnsResolverBuilder.java 77.63% <ø> (ø)
...meria/internal/common/eureka/EurekaClientUtil.java 100.00% <100.00%> (ø)
...com/linecorp/armeria/scala/CommonConversions.scala 65.00% <100.00%> (ø)
...a/internal/testing/webapp/WebAppContainerTest.java 92.53% <100.00%> (-0.97%) ⬇️
...inecorp/armeria/common/ContextAwareBiConsumer.java 0.00% <0.00%> (ø)
...inecorp/armeria/common/ContextAwareBiFunction.java 0.00% <0.00%> (ø)
.../linecorp/armeria/common/ContextAwareConsumer.java 0.00% <0.00%> (ø)
.../linecorp/armeria/common/ContextAwareFunction.java 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jrhee17
jrhee17 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the motivation for this? Did you just go through IDE warning logs?
Anyways, thanks for the cleanup @minwoox 🙇 👍 🙇

@jrhee17 jrhee17 added this to the 1.26.0 milestone Oct 19, 2023
@github-actions
Copy link
Contributor

🔍 Build Scan® (commit: 37e6fad)

Job name Status Build Scan®
build-windows-latest-jdk-19 ❌ (failure) https://ge.armeria.dev/s/cuoqcpq4eciae
build-self-hosted-jdk-8 ✅ https://ge.armeria.dev/s/ei4xpfxjzrvlo
build-self-hosted-jdk-19-snapshot-blockhound ✅ https://ge.armeria.dev/s/obzel2wbzsk4y
build-self-hosted-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/efpsv3o2jmsd4
build-self-hosted-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/fqylaybvwf7pa
build-self-hosted-jdk-17-leak ✅ https://ge.armeria.dev/s/2e2qcvcv33v7w
build-self-hosted-jdk-11 ✅ https://ge.armeria.dev/s/pwrn64syqgcng
build-macos-12-jdk-19 ✅ https://ge.armeria.dev/s/wglrdjhkg5ywa

@minwoox
Copy link
Contributor Author

minwoox commented Oct 19, 2023

I've used -Xlint:deprecation.
https://discuss.gradle.org/t/what-is-xlint-deprecation-and-how-to-use-it/40270/5
While I was creating the PR that updates dependencies, I found that it was challenging to make changes after APIs are gone. 😉

@minwoox minwoox merged commit 3ce0a5f into line:main Oct 19, 2023
13 of 14 checks passed
@minwoox minwoox deleted the remove_deprecate_usage branch October 19, 2023 07:17
Bue-von-hon pushed a commit to Bue-von-hon/armeria that referenced this pull request Nov 10, 2023
@minwoox @Bue-von-hon
Remove deprecated API usages (line#5249)
4a981df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@minwoox @ikhoon @jrhee17