Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat FlagsProviderTest #5027

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Reformat FlagsProviderTest #5027

merged 1 commit into from
Jul 17, 2023

Conversation

trustin
Copy link
Member

@trustin trustin commented Jul 12, 2023

.. for aesthetics' sake

@trustin
Reformat FlagsProviderTest
f5b0426 
.. for aesthetics' sake
@trustin trustin added this to the 1.25.0 milestone Jul 12, 2023
minwoox
minwoox approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jrhee17
jrhee17 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way we can expedite the review process for simple formatting changes like this. Anyways thanks @trustin 👍 🙇 👍

@trustin trustin merged commit cd6c25d into line:main Jul 17, 2023
@trustin trustin deleted the prettier_indentation branch July 17, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@trustin @ikhoon @jrhee17 @minwoox