Fix incorrectly overridden project groups by JvmTestSuite.
#4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `group` was set in JvmTestSuite's configuration to change the test task's group, but `Project.group` was changed unintentionally. https://github.com/line/armeria/blob/e15c7b7809db6d77c6798c237707e942fceb51bb/core/build.gradle#L178-L180 The overriden group caused to publish a Armeria artifact to `Verification` org in Sonatype snapshot storage. https://github.com/line/armeria/actions/runs/5010142242/jobs/8979748543#step:8:1273 Modifications: - Override the group of a test task in `testTask.configure` block. Result: Fixed unintentionally overridden Gradle project group information.
trustin
approved these changes
May 19, 2023
trustin
reviewed
May 19, 2023
kotlin/build.gradle.kts
Outdated
Comment on lines
25
to
26
|
|
||
| targets { |
There was a problem hiding this comment.
armeria/kotlin/build.gradle.kts:25:1 Needless blank line(s) (no-consecutive-blank-lines)
Suggested change
| targets { | |
| targets { |
|
Thanks for the quick review. 🙇♂️ |
|
The publishing task successfully finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
groupwas set in JvmTestSuite's configuration to change the test task's group, butProject.groupwas changed unintentionally.armeria/core/build.gradle
Lines 178 to 180 in e15c7b7
The overridden group caused to publish Armeria artifacts to
Verificationorg in Sonatype snapshot storage.https://github.com/line/armeria/actions/runs/5010142242/jobs/8979748543#step:8:1273
Modifications:
testTask.configureblock.Result:
Fixed unintentionally overridden Gradle project group information.