Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try specifying the github token when fetching the contributor list #4590

Merged
merged 9 commits into from
Dec 27, 2022
Merged

Try specifying the github token when fetching the contributor list #4590

merged 9 commits into from
Dec 27, 2022

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Dec 27, 2022 •
edited
Loading

Motivation:

Use secrets.GITHUB_TOKEN for fetching contributor list

Modifications:

  • Pass secrets.GITHUB_TOKEN as -PgithubToken

Result:

  • Less flakiness

minwoox
minwoox approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@jrhee17 jrhee17 added this to the 1.22.0 milestone Dec 27, 2022
@jrhee17 jrhee17 marked this pull request as ready for review December 27, 2022 04:15
ikhoon
ikhoon approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯💯

@ikhoon ikhoon merged commit 90b1dd0 into line:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin Awaiting requested review from trustin

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhee17 @ikhoon @minwoox