Create correct FieldInfo for renamed object fields in DocService
#4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-yim
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
ks-yim
changed the title
FieldInfo for renamed fields in DocServiceFieldInfo for renamed object fields in DocService
Codecov ReportBase: 74.05% // Head: 74.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4507 +/- ##
============================================
+ Coverage 74.05% 74.06% +0.01%
- Complexity 18167 18183 +16
============================================
Files 1536 1537 +1
Lines 67378 67434 +56
Branches 8520 8533 +13
============================================
+ Hits 49894 49946 +52
- Misses 13412 13418 +6
+ Partials 4072 4070 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ikhoon
approved these changes
Oct 31, 2022
| val defaultValue2: String = "Hello2", | ||
| @JsonProperty("renamed") | ||
| @Description("renamed description") | ||
| val name: String? |
There was a problem hiding this comment.
Should we also add a test for a non-null value?
There was a problem hiding this comment.
Thanks for the review. I will add a test for that.
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Nov 10, 2022
ikhoon
added a commit
that referenced
this pull request
Nov 11, 2022
Motivation: When the target release version changed from 1.21.0 to 1.20.3, some PRs were already merged into the master branch. So their milestone should be changed and the release notes also need to be updated. Modifications: - Add #4515, #4507, #4484 and #4492 to the release notes. Result: Update the missing issues and PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
FieldInfois not correctly rendered inDocServiceif bean field names are overridden by@JsonProperty#4506Modifications:
BeanPropertyDefinition#getInternalNameto find the right constructor parameter or getter.BeanPropertyDefinition#getName#getInternalNameis derived from accessor and is not based on annotations or naming strategy.* Use
@JsonPropertyannotation-based matching strategy to find the right field or constructor parameter for the fields without accessor(getter).#getInternalNameis generated based on annotations or naming strategy if there's no available accessor for a field.Limitation:
@JsonPropertyannotation-based field matching strategy may not cover POJOs without@JsonPropertyand de/serialized with non-default naming strategy .Result:
FieldInfois not correctly rendered inDocServiceif bean field names are overridden by@JsonProperty#4506