Remove warning in task :kotlin:compileKotlin #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscheong01
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4368 +/- ##
=========================================
Coverage 73.53% 73.54%
- Complexity 17648 17652 +4
=========================================
Files 1500 1500
Lines 66010 66010
Branches 8328 8328
=========================================
+ Hits 48540 48544 +4
+ Misses 13254 13249 -5
- Partials 4216 4217 +1
Continue to review full report at Codecov.
|
ikhoon
approved these changes
Jul 28, 2022
| @@ -29,14 +29,14 @@ import kotlinx.coroutines.future.await | |||
| * | |||
| * @see JacksonObjectMapperProvider | |||
| */ | |||
| suspend inline fun <reified T> RestClientPreparation.execute(): ResponseEntity<T> { | |||
| suspend inline fun <reified T : Any> RestClientPreparation.execute(): ResponseEntity<T> { | |||
There was a problem hiding this comment.
Note: https://stackoverflow.com/questions/63535390/how-is-any-upper-bound-in-kotlin-different-from-the-default-no-bounds
I didn't know that <T> bound is the same as <T : Any?>. TIL 🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Noticed some warnings while building the project:
> Task :kotlin:compileKotlin w: Argument -Xopt-in is deprecated. Please use -opt-in instead w: /Users/wjdalstn/Documents/GitHub/armeria/kotlin/src/main/kotlin/com/linecorp/armeria/client/kotlin/CoroutineRestClient.kt: (33, 12): Type parameter 'T' has nullable upper bounds while non-nullable version is expected. This warning will become an error soon. See https://youtrack.jetbrains.com/issue/KT-36770 for details w: /Users/wjdalstn/Documents/GitHub/armeria/kotlin/src/main/kotlin/com/linecorp/armeria/client/kotlin/CoroutineRestClient.kt: (33, 20): Type parameter 'T' has nullable upper bounds while non-nullable version is expected. This warning will become an error soon. See https://youtrack.jetbrains.com/issue/KT-36770 for details w: /Users/wjdalstn/Documents/GitHub/armeria/kotlin/src/main/kotlin/com/linecorp/armeria/client/kotlin/CoroutineRestClient.kt: (41, 12): Type parameter 'T' has nullable upper bounds while non-nullable version is expected. This warning will become an error soon. See https://youtrack.jetbrains.com/issue/KT-36770 for details w: /Users/wjdalstn/Documents/GitHub/armeria/kotlin/src/main/kotlin/com/linecorp/armeria/client/kotlin/CoroutineRestClient.kt: (41, 20): Type parameter 'T' has nullable upper bounds while non-nullable version is expected. This warning will become an error soon. See https://youtrack.jetbrains.com/issue/KT-36770 for detailsPerhaps something related to the definitly non nullable types feature since kotlin 1.6.20
Modifications:
Result:
no warnings!