Add Koltlin nullable type support to AnnotatedService
#4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-yim
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4225 +/- ##
============================================
- Coverage 73.34% 73.34% -0.01%
- Complexity 16952 16978 +26
============================================
Files 1451 1450 -1
Lines 63982 64104 +122
Branches 8026 8061 +35
============================================
+ Hits 46928 47017 +89
- Misses 12964 12991 +27
- Partials 4090 4096 +6
Continue to review full report at Codecov.
|
ikhoon
reviewed
Apr 26, 2022
kotlin/src/test/kotlin/com/linecorp/armeria/server/kotlin/NullableTypeSupportTest.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
…ableTypeSupportTest.kt Co-authored-by: Ikhun Um <ih.pert@gmail.com>
ikhoon
approved these changes
Apr 28, 2022
|
Thanks, it would be nice if we improve the doc, too. I will work on that too. |
trustin
reviewed
Jun 1, 2022
kotlin/src/test/kotlin/com/linecorp/armeria/server/kotlin/NullableTypeSupportTest.kt
Show resolved
Hide resolved
trustin
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
AnnotatedServicerequires@Nullableannotations for nullable resolved values even when it is used with Kotlin which offers nice null-safety with nullable types.Modifications:
isMarkedNullablemethod toKotlinUtil.AnnotatedValueResolver#Builderdetect Kotlin nullable types ofFieldandParameterand allow null values for them.Result:
@Nullableannotations to nullable arguments & fields inAnnotatedServiceif they are Kotlin nullable types(?).AnnotatedServicearguments #4144