Fix data corruption in JettyService #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When JettyService copies the output from Jetty to an HttpData, it has to respect the position of the ByteBuffer provided by Jetty. Modification: - Respect the position of the ByteBuffer provided by Jetty Result: No more data corruption in JettyService
Current coverage is 64.55% (diff: 100%)@@ master #327 diff @@
==========================================
Files 318 318
Lines 12835 12835
Methods 0 0
Messages 0 0
Branches 1916 1916
==========================================
+ Hits 8283 8285 +2
+ Misses 3666 3665 -1
+ Partials 886 885 -1
|
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When JettyService copies the output from Jetty to an HttpData, it has to
respect the position of the ByteBuffer provided by Jetty.
Modification:
Result:
No more data corruption in JettyService