Provide a way to access a parent log from a child log #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `RequestId` is used for tracking the request and the response pair. A request can be executed multiple times by `RetryingClient`. It is difficult to group and trace all retried requests without the request ID of the original request. By accessing the parent log from the current request context, we are able to log the parent and current request ID pair. Modifications: - Add `parent()` to `RequestLogAccess` - Include the request ID of parent to `toString()` Results: - You can now access a parent log from a child log. - `DefaultClientRequest.toString()` contains a parent request ID if available. - Fixes line#2588
trustin
reviewed
Mar 18, 2020
core/src/main/java/com/linecorp/armeria/client/ClientRequestContextWrapper.java
Outdated
Show resolved
Hide resolved
trustin
reviewed
Mar 18, 2020
core/src/main/java/com/linecorp/armeria/common/logging/DefaultRequestLog.java
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java
Outdated
Show resolved
Hide resolved
trustin
reviewed
Mar 18, 2020
core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java
Outdated
Show resolved
Hide resolved
trustin
approved these changes
Mar 18, 2020
core/src/main/java/com/linecorp/armeria/client/DefaultClientRequestContext.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2599 +/- ##
============================================
- Coverage 73.34% 73.32% -0.03%
+ Complexity 11049 11043 -6
============================================
Files 970 971 +1
Lines 42523 42527 +4
Branches 5294 5300 +6
============================================
- Hits 31188 31181 -7
- Misses 8625 8633 +8
- Partials 2710 2713 +3 Continue to review full report at Codecov.
|
|
Thanks a lot, @ikhoon ! |
|
Thanks for reviewing! |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: `RequestId` is used for tracking the request and the response pair. A request can be executed multiple times by `RetryingClient`. It is difficult to group and trace all retried requests without the request ID of the original request. By accessing the parent log from the current request context, we are able to log the parent and current request ID pair. Modifications: - Add `parent()` to `RequestLogAccess` - Include the request ID of parent to `toString()` Results: - You can now access a parent log from a child log. - `DefaultClientRequest.toString()` contains a parent request ID if available. - Fixes line#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RequestIdis used for tracking the request and the response pair.A request can be executed multiple times by
RetryingClient.It is difficult to group and trace all retried requests without the request ID of the original request.
By accessing the parent log from the current request context, we are able to log the parent and current request ID pair.
Modifications:
parent()toRequestLogAccesstoString()inDefaultClientRequestContextResults:
DefaultClientRequest.toString()contains a parent request ID if available.