Make RetryingClient handle negative nano time properly
#2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Client Motivation: `System.nanoTime()` can return a negative number. The sum of `System.nanoTime()` and `responseTimeoutMills` can be zero, even if `responseTimeoutMillis` is positive. Modifications: - Add `isTimeoutEnabled` flag for checking whether the timeout was set or not Result: Remove a potential timeout bug
trustin
approved these changes
Mar 13, 2020
trustin
changed the title
RetryingClient handle negative nano time properly
trustin
pushed a commit
that referenced
this pull request
Mar 13, 2020
Motivation: `System.nanoTime()` can return a negative number. The sum of `System.nanoTime()` and `responseTimeoutMills` can be zero, even if `responseTimeoutMillis` is positive. Modifications: - Add `isTimeoutEnabled` flag for checking whether the timeout was set or not Result: Remove a potential timeout bug
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: `System.nanoTime()` can return a negative number. The sum of `System.nanoTime()` and `responseTimeoutMills` can be zero, even if `responseTimeoutMillis` is positive. Modifications: - Add `isTimeoutEnabled` flag for checking whether the timeout was set or not Result: Remove a potential timeout bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
System.nanoTime()can return a negative number.So the sum of
System.nanoTime()andresponseTimeoutMillscan also be zeroeven if
responseTimeoutMillisis positive.Modifications:
isTimeoutEnabledflag for checking whether the timeout was setor not
Result:
Remove a potential timeout bug