Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default build JDK to Java 12. #2151

Merged
merged 5 commits into from
Oct 4, 2019
Merged

Switch default build JDK to Java 12. #2151

merged 5 commits into from
Oct 4, 2019

Conversation

anuraaga
Copy link
Collaborator

@anuraaga anuraaga commented Oct 3, 2019 •
edited by minwoox
Loading

Fixes #2141

@anuraaga anuraaga marked this pull request as ready for review October 3, 2019 07:12
@codecov
Copy link

codecov bot commented Oct 3, 2019 •
edited
Loading

Codecov Report

Merging #2151 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2151      +/-   ##
============================================
+ Coverage     73.52%   73.58%   +0.05%     
- Complexity     9556     9565       +9     
============================================
  Files           837      837              
  Lines         36830    36830              
  Branches       4542     4542              
============================================
+ Hits          27081    27100      +19     
+ Misses         7419     7403      -16     
+ Partials       2330     2327       -3
Impacted Files Coverage Δ Complexity Δ
...rp/armeria/common/stream/DefaultStreamMessage.java 89.36% <0%> (-1.42%) 53% <0%> (-1%)
...com/linecorp/armeria/server/HttpServerHandler.java 81.14% <0%> (+1.01%) 81% <0%> (+2%) ⬆️
...corp/armeria/common/stream/FixedStreamMessage.java 89.47% <0%> (+1.75%) 23% <0%> (+1%) ⬆️
...a/common/grpc/protocol/ArmeriaMessageDeframer.java 72.33% <0%> (+2.42%) 48% <0%> (+3%) ⬆️
...a/com/linecorp/armeria/common/util/Exceptions.java 39.47% <0%> (+2.63%) 25% <0%> (+2%) ⬆️
...om/linecorp/armeria/server/jetty/JettyService.java 66% <0%> (+2.95%) 24% <0%> (+1%) ⬆️
...meria/common/stream/RegularFixedStreamMessage.java 87.75% <0%> (+6.12%) 14% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb403e...c1fc2b3. Read the comment docs.

@trustin
Copy link
Member

trustin commented Oct 4, 2019

Could you also update the release task in /build.gradle to require Java 12? Maybe should we make the entire build require Java 12 rather than just the release process?

@trustin trustin added the cleanup label Oct 4, 2019
@anuraaga
Copy link
Collaborator Author

anuraaga commented Oct 4, 2019

Thanks indeed. Changed the release task to require Java 12, and added a check for normal compile that verifies >=12 (don't think we have to require exactly 12 for normal building during development)

trustin
trustin reviewed Oct 4, 2019
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@trustin trustin added this to the 0.94.1 milestone Oct 4, 2019
minwoox
minwoox approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anuraaga!

build.gradle Outdated Show resolved Hide resolved
ikhoon
ikhoon approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin trustin merged commit 915d210 into line:master Oct 4, 2019
eugene70 pushed a commit to eugene70/armeria that referenced this pull request Oct 16, 2019
@anuraaga
Switch default build JDK to Java 12. (line#2151)
a353e4d 
Fixes line#2141
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
@anuraaga @trustin
Switch default build JDK to Java 12. (line#2151)
11e89ed 
Fixes line#2141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin trustin approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.

Raise build JDK requirement to Java 12
4 participants
@anuraaga @trustin @ikhoon @minwoox