Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lncfg: allow no auth on private addresses #4473

Merged
merged 2 commits into from
Sep 15, 2020
Merged

lncfg: allow no auth on private addresses #4473

merged 2 commits into from
Sep 15, 2020

Conversation

yyforyongyu
Copy link
Member

Fixes #3080

previous discussion can be found in #4258

bhandras
bhandras reviewed Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

I was wondering if you could also update the doc for NoMacaroons in config.go and possibly docs/macaroons.md too to fully document that flag.

@Roasbeef Roasbeef added rpc Related to the RPC interface security General label for issues/PRs related to the security of the software labels Jul 20, 2020
@yyforyongyu yyforyongyu force-pushed the allow-no-auth-private-addr branch from 5f1e98f to 273349f Compare July 21, 2020 10:12
@yyforyongyu
Copy link
Member Author

Changes LGTM 👍

I was wondering if you could also update the doc for NoMacaroons in config.go and possibly docs/macaroons.md too to fully document that flag.

Sure thing. Done.

@yyforyongyu yyforyongyu requested a review from bhandras July 21, 2020 10:17
bhandras
bhandras approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roasbeef Roasbeef added this to the 0.12.0 milestone Jul 22, 2020
@Roasbeef Roasbeef requested a review from halseth July 22, 2020 02:55
@Roasbeef Roasbeef added the v0.12 label Jul 22, 2020
@halseth halseth requested a review from guggero July 22, 2020 06:58
guggero
guggero approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful addition, especially for docker environments.
LGTM, just a few nits.

config.go Outdated Show resolved Hide resolved
lncfg/address_test.go Show resolved Hide resolved
docs/macaroons.md Show resolved Hide resolved
@yyforyongyu yyforyongyu force-pushed the allow-no-auth-private-addr branch from 273349f to f1a9ec9 Compare July 22, 2020 14:51
@yyforyongyu yyforyongyu force-pushed the allow-no-auth-private-addr branch from f1a9ec9 to 86d5fac Compare July 22, 2020 14:53
@halseth halseth removed their request for review July 22, 2020 17:20
@Roasbeef Roasbeef merged commit ffe7c3e into lightningnetwork:master Sep 15, 2020
@yyforyongyu yyforyongyu deleted the allow-no-auth-private-addr branch September 15, 2020 03:23
@zoedberg zoedberg mentioned this pull request Oct 10, 2020
Closed
@guggero guggero mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinrzachman calvinrzachman calvinrzachman approved these changes

@guggero guggero guggero approved these changes

@bhandras bhandras bhandras approved these changes

Assignees
No one assigned
Labels
rpc Related to the RPC interface security General label for issues/PRs related to the security of the software v0.12
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Allow no authentication when binding to private non-routable addresses
5 participants
@yyforyongyu @bhandras @guggero @calvinrzachman @Roasbeef