Ability to configure neutrino useragent #4353
Conversation
Expose the neutrino `UserAgentName` config option. This can be set by starting lnd with the `--neutrino.useragentname=` flag.
Expose the neutrino `UserAgentVersion` config option. This can be set by starting lnd with the `--neutrino.useragentversion=` flag.
Roasbeef
added
enhancement
| @@ -785,6 +785,7 @@ func initNeutrinoBackend(cfg *Config, chainDir string) (*neutrino.ChainService, | |||
|
|
|||
| neutrino.MaxPeers = 8 | |||
| neutrino.BanDuration = time.Hour * 48 | |||
| neutrino.UserAgentName = cfg.NeutrinoMode.UserAgentName | |||
There was a problem hiding this comment.
just noting: it would be best to avoid overwriting global variables in the package, but given we already do that above that is out of scope for this PR :)
however, currently neutrino.UserAgentName defaults to "neutrino". if the user doesn't set --neutrino.useragentname then this will be set to an empty string. we can fix this by setting a default value on lncfg.Neutrino, similar to what is done for bitcoind and btcd subconfigs. this default can simply be neutrino.UserAgentName since it'll be read before being overwritten here. the same comment applies to the next commit
There was a problem hiding this comment.
I've added a new commit that sets these default values.
|
So do we want to block on fixing that issue, or is this g2g? |
It should be a simple fix. I can pick it up if @mrfelton is unable to continue. |
mrfelton
force-pushed
the
feat/neutrino-user-agent
branch
from
b6f630a to
51a5137
Compare
|
@Roasbeef the primary comment has been addressed. longer term we should figure out a solution in the neutrino repo for modifying these values without overwriting globals |
This PR adds the ability to alter the neutrino useragent string so that neutrino clients can identify themselves as they please.
It exposes the neutrino
UserAgentVersionandUserAgentNameconfig options which can be set by starting lnd with the--neutrino.useragentversion=and--neutrino.useragentname=flags.This enables btcd nodes to better identify connecting clients. For example, it could be used in conjunction with btcd's
agentblacklistandagentwhitelistsettings to ensure that only clients that identify themselves in a specific way are allowed to connect.