routing: check max routing info size #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2019
joostjager
force-pushed
the
check-max-onion-size
branch
2 times, most recently
from
13f9029 to
6df01de
Compare
joostjager
force-pushed
the
check-max-onion-size
branch
7 times, most recently
from
0689a2c to
9063c3d
Compare
cfromknecht
reviewed
Dec 18, 2019
joostjager
force-pushed
the
check-max-onion-size
branch
3 times, most recently
from
f80d87e to
810dfbc
Compare
joostjager
changed the title
joostjager
force-pushed
the
check-max-onion-size
branch
2 times, most recently
from
0d9a287 to
c3fa681
Compare
This prevents inefficient key conversions in a follow up commit that change the inner pathfinding loop.
joostjager
force-pushed
the
check-max-onion-size
branch
2 times, most recently
from
5452295 to
6d5d415
Compare
|
Itest failing, need to investigate |
cfromknecht
reviewed
Dec 20, 2019
To allow execution within an existing tx.
Also prepares for payload size tracking during pathfinding
joostjager
force-pushed
the
check-max-onion-size
branch
from
6d5d415 to
790e61f
Compare
|
Itest fixed, db transaction problem for which I added a commit |
joostjager
force-pushed
the
check-max-onion-size
branch
from
4a254f4 to
1a86460
Compare
cfromknecht
approved these changes
Dec 20, 2019
Enable the test again and use a programmatically built network.
Also the max hop count check can be removed, because the real bound is the payload size. By moving the check inside the search loop, we now also backtrack when we hit the limit.
joostjager
force-pushed
the
check-max-onion-size
branch
from
1a86460 to
c84e57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies pathfinding to check the accumulated total payload size during search. This ensures that we will never find a route that exceeds the limit of 1300 bytes.
In order to execute this check, it is necessary to take into account whether nodes along the route support tlv (this influences the payload size). The size of custom records that are possibly present is added as well.