This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Added collection and export of Earliest Offset #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafka_partition_earliest_offset is now gathered and exported for all of the topic partitions which had been gathering the latest offset.
seglo
reviewed
Oct 3, 2019
README.md
Outdated
| @@ -125,7 +132,7 @@ file of the accompanying Helm Chart. | |||
| You can install the chart from the local filesystem. | |||
|
|
|||
| ``` | |||
| helm install https://github.com/lightbend/kafka-lag-exporter/releases/download/v0.5.4/kafka-lag-exporter-0.5.4.tgz | |||
| helm install https://github.com/lightbend/kafka-lag-exporter/releases/download/v0.5.5/kafka-lag-exporter-0.5.5.tgz | |||
There was a problem hiding this comment.
Do you mind reverting the changes to update the version for the example commands in the README? I'd like it to reflect the current released version for people who browse the project homepage. The release process will automatically update it.
| @@ -13,5 +13,5 @@ echo helm install $RELEASE_URL | |||
| sed -i -r "s/helm install http\S*/helm install ${RELEASE_URL_ESCAPED}/g" $DIR/../README.md | |||
|
|
|||
| echo Update README.md Running Docker Image version to: | |||
| echo lightbend/kafka-lag-exporter:0.5.0 | |||
| echo lightbend/kafka-lag-exporter:${VERSION} | |||
seglo
approved these changes
Oct 7, 2019
seglo
suggested changes
Oct 7, 2019
|
I smoke tested the branch though and it looks good. 👍 |
|
Ok changed the readme references to be for 0.5.4. Wasn't sure if I should change the |
seglo
approved these changes
Oct 7, 2019
anbarasantr
pushed a commit
to anbarasantr/kafka-lag-exporter
that referenced
this pull request
Nov 24, 2019
* Added collection and export of Earliest Offset kafka_partition_earliest_offset is now gathered and exported for all of the topic partitions which had been gathering the latest offset. * referencing 0.5.4 in readme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka_partition_earliest_offset is now gathered and exported for all of the topic partitions which had been gathering the latest offset. Closes #67