This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Adding support to control which prometheus metrics to expose #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
approved these changes
Sep 15, 2019
There was a problem hiding this comment.
Great work @khorshuheng. Thanks for adding the test for PrometheusEndpointSink. It would be nice if the remove logic can be cleaned up, but it's not necessary. Let me know what you think.
| def clustersGlobalLabels(): ClusterGlobalLabels = { | ||
| clusters.map { cluster => | ||
| cluster.name -> cluster.labels | ||
| }.toMap |
| metrics.foreach { case (_, gaugeDefinitionsForCluster) => | ||
| val globalLabelValuesForCluster = clusterGlobalLabels.getOrElse(m.clusterName, Map.empty) | ||
| gaugeDefinitionsForCluster.get(m.definition).foreach(_.remove(globalLabelValuesForCluster.values.toSeq ++ m.labels: _*)) | ||
| } |
There was a problem hiding this comment.
Thanks for fixing this.
[minor] This could be made more clear with a for expression.
There was a problem hiding this comment.
I have substituted foreach with for expression. Let me know if the changes is what you have in mind.
|
LGTM. Thanks @khorshuheng. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #43
New configuration exposed: metric-whitelist. PrometheusEndpointSink will report or remove metrics based on the list of regex.
This PR also added test cases for PrometheusEndpointSink, and fix a bug where metrics removal does not consider global tags.