Support .yml YAML files in ember-intl functionality #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patocallaghan
commented
Apr 26, 2022
Codecov Report
@@ Coverage Diff @@
## component-context-info-origin #384 +/- ##
=================================================================
- Coverage 72.40% 72.35% -0.05%
=================================================================
Files 57 57
Lines 4871 4884 +13
Branches 946 949 +3
=================================================================
+ Hits 3527 3534 +7
- Misses 1344 1350 +6
Continue to review full report at Codecov.
|
lifeart
pushed a commit
that referenced
this pull request
Apr 26, 2022
# [2.24.0](v2.23.0...v2.24.0) (2022-04-26) ### Features * Support .yml YAML files ([#384](#384)) ([e150ba7](e150ba7))
|
@patocallaghan, |
|
Thanks @lifeart 🎉 How soon does it take for this to be "published"? Should I reload my VSCode to pick up the new changes? (Sorry if these are silly questions) |
|
Should take about 5-15 minutes to be available in VSCode store, just search for it, and if it's installed - auto-update will be downloaded, restart is required |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to lifeart/els-intl-addon#5 (comment)
Issue: #383
While the "official" file extension for YAML is
.yamlmany resources online still use.ymlas the file extension of YAML. The application I work in has been using.ymlfor years and we'd love to use this addon without having to rename the files.Ember Intl itself supports both the
.yamland.ymlextension.