Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus detector and immersive mode improvements #539

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Focus detector and immersive mode improvements #539

merged 6 commits into from
Feb 8, 2024

Conversation

veloce
Copy link
Contributor

@veloce veloce commented Feb 7, 2024

So far we've been relying on RouterObserver and RouteAware widgets to react to screen changes but this solution had flaws.

In this PR we're replacing it with a FocusDetector based solution, much more robust.

  • Immersive mode should now behave properly (allowing android back swipe gesture on screens pushed above a board screen)
  • No more issues with root navigator vs navigator to detect screen changes
  • Future proof with coming deep links when we need to ensure a websocket connection is created again when a hidden screen gets visibility back

@veloce veloce marked this pull request as ready for review February 8, 2024 10:02
@veloce veloce merged commit 9266743 into main Feb 8, 2024
3 checks passed
@veloce veloce deleted the focus_detector branch February 8, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@veloce