Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'logger' not defined errors and engine_opts #162

Merged
merged 3 commits into from
Dec 16, 2018
Merged

Fix 'logger' not defined errors and engine_opts #162

merged 3 commits into from
Dec 16, 2018

Conversation

ShailChoksi
Copy link
Collaborator

No description provided.

@ShailChoksi ShailChoksi changed the title Fix 'logger' not defined errors, add pondering and engine_opts Fix 'logger' not defined errors and engine_opts Dec 15, 2018
lichess-bot.py Outdated
best_move = engine.search(board, upd["wtime"], upd["btime"], upd["winc"], upd["binc"])
li.make_move(game.id, best_move)
game.abort_in(config.get("abort_time", 20))
elif engine_cfg.get("uci_ponder", False) and engine_cfg.get("protocol") == "uci":
engine.stop()
engine.ponder(board)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably if the game is over pondering is unnecessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking of removing pondering from this PR since I read the last discussion on how it was not following the uci protocol.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove - it actually does follow the uci specs now including handling ponderhit correctly.

@@ -10,26 +10,11 @@ def create_engine(config, board):
cfg = config["engine"]
engine_path = os.path.join(cfg["dir"], cfg["name"])
engine_type = cfg.get("protocol")
lczero_options = cfg.get("lczero")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example configuration config.yml.default still contains a section named lczero

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ShailChoksi ShailChoksi merged commit 6cf5586 into master Dec 16, 2018
@ShailChoksi ShailChoksi deleted the ponder branch December 18, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants