Fix build for c89 with Visual C++ 9 #2869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzoz
approved these changes
May 28, 2020
There was a problem hiding this comment.
LGTM. The commits need to be squashed and made to follow the commit guideline, but this can be done while landing. Thanks for your contribution!
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1920/
bnoordhuis
approved these changes
Jun 12, 2020
|
Landed in ff3ab31, thanks! |
|
Thanks! |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
Fixes: libuv#2861 PR-URL: libuv#2869 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
#2861 src/win/udp.c: Incompatible with Visual C++ 9/C89 build windows
src/win/udp.c:
STATIC_ASSERT (...) for C89 must be used in top of functions