-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pthread_barrier_wait: properly check the wait condition #644
Conversation
- minor code-style fixes;
dae9e11
to
091e9d5
Compare
Yeap, verified with Coverity - that fixes the issue. |
@z3ntu any chance you know why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review is a good thing
still need to verify it locally though... |
Looks like the auth token expired, for now we need to uninstall the github app and reinstall the hottub bridge. |
Try if now is enough |
No, not even in this repository I have much access and nothing in the libusb organization (where the github app installations are). https://github.com/organizations/libusb/settings/installations . IIRC it's pretty high permissions needed for doing this, and on the organization level, not repository level.. Or we can do it like last time, request install of the app and then I do the sr.ht oauth setup, then that should be done, see #462 (comment) and following :) So: organization admin goes to the GitHub apps settings, then uninstalls the current install, goes to https://hottub.emersion.fr/ and reinstall. It should go to sr.ht for login, either give me this url or maybe even better, the url for the settings of the github app (which includes some numeric ID in the url). Then I reauthenticate from my side using that. |
After uninstalling/installing the hottub bridge I immediatelly getting redirected to Authorisation page. |
All good with |
Nice. Hopefully the refresh token things work by the time the token expires, if not we'll know what we have to do 1 year from now ;) |
Fixes: #643