Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread_barrier_wait: properly check the wait condition #644

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

Youw
Copy link
Member

@Youw Youw commented Nov 19, 2023

Fixes: #643

@Youw Youw force-pushed the macos-barrier-fix branch from dae9e11 to 091e9d5 Compare November 19, 2023 15:36
@Youw
Copy link
Member Author

Youw commented Nov 19, 2023

Yeap, verified with Coverity - that fixes the issue.

@Youw Youw added bug Something isn't working macOS Related to macOS backend labels Nov 20, 2023
@Youw
Copy link
Member Author

Youw commented Nov 20, 2023

@z3ntu any chance you know why builds.sr.ht fails?

Copy link
Member Author

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review is a good thing

mac/hid.c Outdated Show resolved Hide resolved
mac/hid.c Outdated Show resolved Hide resolved
@Youw
Copy link
Member Author

Youw commented Nov 20, 2023

still need to verify it locally though...

@z3ntu
Copy link
Collaborator

z3ntu commented Nov 21, 2023

@z3ntu any chance you know why builds.sr.ht fails?

Looks like the auth token expired, for now we need to uninstall the github app and reinstall the hottub bridge.
There have been recently patches to resolve this limitation by supporting oauth refresh token so this shouldn't be a problem in the future.
I don't remember exactly what permissions you gave me to install it but if you give me those permissions again I'll uninstall+reinstall the GitHub app :)

@Youw
Copy link
Member Author

Youw commented Nov 21, 2023

Try if now is enough

@z3ntu
Copy link
Collaborator

z3ntu commented Nov 22, 2023

image

No, not even in this repository I have much access and nothing in the libusb organization (where the github app installations are). https://github.com/organizations/libusb/settings/installations . IIRC it's pretty high permissions needed for doing this, and on the organization level, not repository level..

Or we can do it like last time, request install of the app and then I do the sr.ht oauth setup, then that should be done, see #462 (comment) and following :)

So: organization admin goes to the GitHub apps settings, then uninstalls the current install, goes to https://hottub.emersion.fr/ and reinstall. It should go to sr.ht for login, either give me this url or maybe even better, the url for the settings of the github app (which includes some numeric ID in the url). Then I reauthenticate from my side using that.

@Youw
Copy link
Member Author

Youw commented Nov 22, 2023

After uninstalling/installing the hottub bridge I immediatelly getting redirected to Authorisation page.
I've emailed you the authorisation link. See if that would work.

@Youw Youw merged commit 7011fa9 into master Nov 22, 2023
18 checks passed
@Youw Youw deleted the macos-barrier-fix branch November 22, 2023 10:26
@Youw
Copy link
Member Author

Youw commented Nov 22, 2023

All good with builds.sr.ht.
Thanks @z3ntu!

@z3ntu
Copy link
Collaborator

z3ntu commented Nov 22, 2023

Nice. Hopefully the refresh token things work by the time the token expires, if not we'll know what we have to do 1 year from now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS Related to macOS backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: pthread_barrier_wait impropper wait condition
2 participants