udev.rules documentation improvement #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recently discovered (thanks @tresf), the `TAG+="uaccess"` has to be used before `73-seat-late.rules` and not before `70-uaccess.rules`. Technically it doesn't harm, to have a more restrictive recommenration, but it was not technically currect. Refference on `uaccess` TAG consumption: [1](https://github.com/systemd/systemd/blob/3a1220eedfb65355c387c29584380742a21917aa/src/login/73-seat-late.rules.in), [2](https://www.apt-browse.org/browse/debian/wheezy/main/amd64/systemd/44-11+deb7u4/file/lib/udev/rules.d/73-seat-late.rules).
Be-ing
reviewed
Aug 24, 2021
| # NOTE: these rules must have priorty before 73-seat-late.rules. | ||
| # (Small discussion/explanation in systemd repo: | ||
| # https://github.com/systemd/systemd/issues/4288#issuecomment-348166161) | ||
| # for example, name the file /etc/udev/rules.d/70-my-application-hid.rules. |
There was a problem hiding this comment.
Suggested change
| # for example, name the file /etc/udev/rules.d/70-my-application-hid.rules. | |
| # for example, name the file /etc/udev/rules.d/72-my-application-hid.rules. |
There was a problem hiding this comment.
How about renaming the file to 72-hid.rules?
So there is a standard set of rules that adds a uaccess TAG (70-uaccess.rules) with priority 70.
I'm thinking maybe having and example with the same priority would be nit.
|
How about renaming the file to |
|
I tested changing the priority of Mixxx's udev rule file and confirmed this is correct. |
mcuee
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recently discovered (thanks @tresf), the
TAG+="uaccess"has to be usedbefore
73-seat-late.rulesand not before70-uaccess.rules.Technically it doesn't harm, to have a more restrictive recommenration,
but it was not technically currect.
Refference on
uaccessTAG consumption:1, 2.
Relates to: #276, systemd/systemd/issues/4288.