Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mel_to_stft example, resolves #1672 #1673

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fixed mel_to_stft example, resolves #1672 #1673

merged 1 commit into from
Feb 18, 2023

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Feb 18, 2023

Reference Issue

Fixes #1672

What does this implement/fix? Explain your changes.

Resolves an error in the docstring for mel_to_stft.

Any other comments?

No code changes, this can merge immediately.

@bmcfee bmcfee added the documentation Issues relating to docstrings, examples, and documentation build label Feb 18, 2023
Copy link
Contributor

@lostanlen lostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another showtime for util.abs2!

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 98.79% // Head: 98.79% // No change to project coverage 👍

Coverage data is based on head (6f20ea8) compared to base (3608f17).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          34       34           
  Lines        4563     4563           
=======================================
  Hits         4508     4508           
  Misses         55       55           
Flag Coverage Δ
unittests 98.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
librosa/feature/inverse.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bmcfee bmcfee merged commit 1f770e8 into main Feb 18, 2023
@bmcfee bmcfee deleted the 1672-fix branch February 18, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to docstrings, examples, and documentation build
Development

Successfully merging this pull request may close these issues.

Confused by example in mel_to_stft doc
2 participants