Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify yamux stream flow control terminilogy #621

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jul 2, 2024

  • Flow control is ruled per stream via window updates
  • Initial windows size is 262144 bytes

@MarcoPolo MarcoPolo self-requested a review July 3, 2024 04:52
@sukunrt sukunrt self-requested a review July 16, 2024 11:07
@sukunrt
Copy link
Member

sukunrt commented Aug 22, 2024

@MarcoPolo thoughts? This looks correct to me.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

@sukunrt sukunrt changed the title Clarify yamux a bit Clarify yamux stream flow control terminilogy Aug 23, 2024
@sukunrt sukunrt merged commit 1fec30e into libp2p:master Aug 23, 2024
@sukunrt
Copy link
Member

sukunrt commented Aug 23, 2024

Thanks @marten-seemann

@flcl42 flcl42 deleted the patch-1 branch September 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants