fix(pubsub): remove "Implementation note" about setting message_id_fn
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f go-libp2p-pubsub
cce
changed the title
message_id_fn
mxinden
reviewed
Jul 13, 2023
There was a problem hiding this comment.
To me the two options are equivalent:
- a top-level
message_id_fn(message)that returns differentid's dependent onmessage.topic - one
message_id_fn(message)per topic, where each individual function ignores themessage.topicfield.
Unless I am missing something and there indeed is a difference, I suggest simply removing the paragraph.
|
Great! I wasn't sure if removing the paragraph was too drastic. I can do that too |
|
I removed the note — main reason for opening this PR was because I was reading the spec and go-libp2p-pubsub docs at the same time and noticed it wasn't up to date. I think code organization would be the only difference between preferring a global message_id_fn that checks the topic, vs being able to set per-topic |
mxinden
approved these changes
Jul 16, 2023
mxinden
approved these changes
Jul 16, 2023
mxinden
changed the title
message_id_fnmessage_id_fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates an old note in the message ID section of the pubsub spec to reflect that go-libp2p-pubsub currently supports topic-specific message ID configuration, using
WithTopicMessageIdFn.