define the ProviderAddrTTL in this repo #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
reviewed
Nov 20, 2022
| // ProviderAddrTTL is the TTL of an address we've received from a provider. | ||
| // This is also a temporary address, but lasts longer. After this expires, | ||
| // the records we return will require an extra lookup. | ||
| const ProviderAddrTTL = time.Minute * 30 |
There was a problem hiding this comment.
This was a var in go-libp2p, presumably for customization? Any reason you changed to const? (I don't really feel strongly here just want the rationale written down somewhere.)
There was a problem hiding this comment.
- It wasn't used, as far as I can see.
- Using package-level globals for configuration is an antipattern.
No strong feelings though, happy to change it back if desired.
guseggert
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously defined in the
peerstorepackage, but we removed it from there (see libp2p/go-libp2p@0e1b7df), because kad was the only consumer.This PR will be necessary to update go-libp2p to v0.24.0, here and in kubo.