remote: introduce remote_ready_cb, deprecate resolve_url callback #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may want to override the URL on a particular instance of a remote, instead of updating the configuration. Previously, users could use a callback to do this, but this is not particularly idiomatic.
ethomson
force-pushed
the
ethomson/custom_url
branch
from
b054388 to
d90350a
Compare
Introduce a new callback that fires when the remote is ready to connect.
Using a callback to set a resolve_url is not particularly idiomatic. Deprecate it in favor of the `set_instance_url` and `set_instance_pushurl` functions which can now be called from the `git_remote_ready_cb` callback.
ethomson
force-pushed
the
ethomson/custom_url
branch
from
d90350a to
7442c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my goal of making
git_bufa data structure that we use to provide data to users, instead of taking data from users, this deprecates theresolve_urlcallback. It provides a replacement callbackgit_remote_ready_cbthat is fired at the same time. Users can then call the newset_instance_urlfunctions on a remote to update the URLs if they so desire.