Check git_signature_dup failure #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git_signature_dup can have an allocation failure
lhchavez
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
I figured these calls should probably be checked, since
git_signature_dupcan have an allocation failure.
yes they should!
There's also one in
hunk_from_entry, but I'm not sure if that call has to be checked becauseblame_internaldoesn't checkhunk_from_entryfor any errors (should it?).
yeah, anything that has an allocation failure should be checked. but this change is good as-is. thanks for making these!
|
Thanks @mamapanda! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured these calls should probably be checked, since
git_signature_dupcan have an allocation failure.There's also one in
hunk_from_entry, but I'm not sure if that call has to be checked becauseblame_internaldoesn't checkhunk_from_entryfor any errors (should it?).