Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git 2.40.0 index.skipHash incompatible with libgit2 #6531

Closed
ehuss opened this issue Mar 15, 2023 · 3 comments · Fixed by #6738
Closed

git 2.40.0 index.skipHash incompatible with libgit2 #6531

ehuss opened this issue Mar 15, 2023 · 3 comments · Fixed by #6738

Comments

@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2023

The recently introduced index.skipHash config setting seems to create index files that are incompatible with libgit2. This option is enabled with feature.manyFiles which some users have enabled to improve performance.

See: git/git@ffd9238

Reproduction steps

  1. With git 2.40.0, run git clone -c index.skipHash=true https://github.com/libgit2/libgit2.git
  2. Run libgit2/build/examples/lg2 status

Expected behavior

Successfully opens the repo.

Actual behavior

Fails with the error:

Could not get status [-1] - invalid data in index - calculated checksum does not match expected

Version of libgit2 (release number or SHA1)

8f8e805 or 1.6.2

Operating system(s) tested

Any
@ehuss ehuss mentioned this issue Mar 15, 2023
Closed
@ethomson
Copy link
Member

Oy. Thanks for opening the issue.

@pololi-stripe pololi-stripe mentioned this issue Mar 21, 2023
Closed
@extrawurst extrawurst mentioned this issue Mar 23, 2023
Closed
@tummychow tummychow mentioned this issue Apr 6, 2023
Open
@arxanas arxanas mentioned this issue Apr 18, 2023
Closed
@Whirlwind
Copy link

Any process?

@1024bees 1024bees mentioned this issue May 14, 2023
Closed
@oknozor oknozor mentioned this issue May 23, 2023
Closed
@romkatv romkatv mentioned this issue Jul 25, 2023
Closed
@epage epage mentioned this issue Aug 27, 2023
Open
2 tasks
@parnic parnic mentioned this issue Feb 16, 2024
Merged
@thufschmitt thufschmitt mentioned this issue Feb 19, 2024
Open
@mtalexan
Copy link

git actually enables feature.manyFiles automatically with the version of git it's introduced in. So it can be expected that every user with a recent version git will have it set except for the very very few that follow git closely enough to know it was added, and have a specific reason to disable it.

@DefaultRyan DefaultRyan mentioned this issue Apr 17, 2024
Open
@Cykelero Cykelero mentioned this issue Jul 3, 2024
Open
@altsem altsem mentioned this issue Jul 4, 2024
Closed
raylu added a commit to raylu/git-whence that referenced this issue Jul 19, 2024
@raylu
upgrade git2
22ed141 
this pulls in the fix for libgit2/libgit2#6531
which should fix indexes created with feature.manyFiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support index.skipHash true config
4 participants
@ehuss @ethomson @Whirlwind @mtalexan