win32: ensure that the MSVC build doesn't terminate when MinGW fails #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `matrix`-strategy builds, GitHub actions will terminate all related matrix legs when one of them fails. Disabling `fail-fast` knocks this behavior off.
DHowett
force-pushed
the
dev/duhowett/fix-msvc
branch
from
4f37001 to
e318526
Compare
|
A-ha! That would explain the MSVC builds getting cancelled. Thanks for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
matrix-strategy builds, GitHub actions will terminate all related matrix legs when one of them fails.Disabling
fail-fastknocks this behavior off.