Build mappy via Makefile and libminimap2.a #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merged. |
|
That's great! Can we get mappy 2.25 (or similar) on PyPI, please? |
|
I can't compile mappy with python setup.py build_extIn addition, because *.c files are not included in setup.py, these files are not included in the mappy package. The PyPI package is also broken. I will revert back to the old setup.py. Hope you can find a better solution for Apple M1. See also #1057. |
lh3
added a commit
that referenced
this pull request
Apr 29, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #867.
pip install mappycurrent fails with compile errors around neon. I suspect at some point the install worked but thesetup.pyhasn't kept pace with the Makefile in terms of how things should be built on ARM.This implements one method of ensuring mappy build is in sync with that defined in Makefile for minimap2. Alternatively the Makefile if statements need translating to the
setup.py.