CI: uncomment windows CI job to see if it passes #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxyd
added
CI
|
Yes, I also attempted it here #5032, it fails |
I see. I think the way to go here would be look one by one at the CI log and fix it in our branch directly, and push the changes to see where it fails again. |
Precisely, that is how you fix it :) |
|
If you have access to windows, then better is to reproduce it locally, attempts to check directly on CI takes a lot of time to iterate. Else, comment out other CI tests, just keep windows, this way you can reduce load on runner and make tests run faster. |
|
The tests passed in the last commit, so I've uncommented all the other CI jobs and enabled auto-merge (nothing important to be reviewed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.