Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: try uncommenting C/C++ CI job #5046

Closed
wants to merge 1 commit into from
Closed

CI: try uncommenting C/C++ CI job #5046

wants to merge 1 commit into from

Conversation

gxyd
Copy link
Contributor

@gxyd gxyd commented Oct 14, 2024

No description provided.

@gxyd gxyd added CI Continuous Integration simplifier pass Pull Requests related to the simplifier pass. labels Oct 14, 2024
@gxyd gxyd mentioned this pull request Oct 14, 2024
Closed
41 tasks
@gxyd gxyd marked this pull request as draft October 15, 2024 08:15
@assem2002
Copy link
Contributor

I'll try handling this one.

@assem2002
Copy link
Contributor

assem2002 commented Oct 17, 2024 •
edited
Loading

Ondrej suggested that we can just comment out the failing test matmul_01.f90. After merging simplifier into main, we can work on getting this single test working.
from my end it seems that matmul_01.f90 has some issue with arraySection arrayC2 access parts of array C and modifies it which makes the program fails. I'll give it a look again, but we can just modify this PR to comment out that single test to get simplifier merged. @gxyd

@certik
Copy link
Contributor

certik commented Oct 17, 2024

Yes, as long a this matmul_01.f90 test works with LLVM, we can fix the C++ backend after we merge simplifier.

@gxyd
Copy link
Contributor Author

gxyd commented Oct 22, 2024

Closing this PR, as it isn't needed anymore.

@gxyd gxyd closed this Oct 22, 2024
@gxyd gxyd deleted the ci_uncomment_C_CPP branch October 22, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration simplifier pass Pull Requests related to the simplifier pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gxyd @assem2002 @certik