Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): replace chalk with picocolors #940

Merged
merged 3 commits into from
Sep 28, 2024
Merged

fix(deps): replace chalk with picocolors #940

merged 3 commits into from
Sep 28, 2024

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Sep 28, 2024 •
edited
Loading

Description

Replace chalk with something else

Motivation and Context

migrate to a smaller dependency named picocolors and it is also used by the big players like Vite, Vitest, ...

How Has This Been Tested?

locally tested it

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (ac63494) to head (9c82659).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
+ Coverage   97.93%   97.93%   +0.01%     
==========================================
  Files         147      147              
  Lines        8958     8959       +1     
  Branches     2262     2262              
==========================================
+ Hits         8772     8773       +1     
  Misses        185      185              
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title fix: migrate chalk to picocolors fix(deps): migrate chalk to picocolors Sep 28, 2024
@ghiscoding ghiscoding changed the title fix(deps): migrate chalk to picocolors fix(deps): replace chalk with picocolors Sep 28, 2024
@ghiscoding ghiscoding merged commit 7850c65 into main Sep 28, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/migrate-picocolors branch September 28, 2024 17:31
@ghiscoding ghiscoding mentioned this pull request Oct 7, 2024
Merged
9 tasks
@ghiscoding ghiscoding mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding