Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(version): option to not ignore scripts on lock update, fixes #877 #881

Merged
merged 2 commits into from
Jun 22, 2024
Merged

feat(version): option to not ignore scripts on lock update, fixes #877 #881

merged 2 commits into from
Jun 22, 2024

Conversation

ghiscoding
Copy link
Member

Description

Option to not pass --ignore-scripts while updating the lock file after the version bump.

Motivation and Context

  • fixes --sync-workspace-lock issue #877
  • Lerna version should ignore running npm script by default unless the new CLI argument --run-scripts-on-lockfile-update is provided. By default, the new behavior is to ignore running the npm scripts when synching lock file after the Lerna version command.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov Codecov
Copy link

codecov bot commented Jun 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (5bc0d9a) to head (84f1199).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
+ Coverage   97.74%   97.74%   +0.01%     
==========================================
  Files         155      155              
  Lines        7901     7915      +14     
  Branches     1928     1929       +1     
==========================================
+ Hits         7722     7736      +14     
  Misses        178      178              
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 1b78b53 into main Jun 22, 2024
6 checks passed
@ghiscoding ghiscoding deleted the feat/sync-lock-with-scripts branch June 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--sync-workspace-lock issue
1 participant
@ghiscoding