Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep only peerDependenciesMeta without peerDeps, fixes #578 #585

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Apr 21, 2023

Description

Rollback a portion of PR #578, it might be ok to keep only peerDependenciesMeta without peerDependencies in the Lerna-Lite CLI which hopefully still fixes PR #573

Motivation and Context

PR #578 caused an issue when trying to publish latest Lerna-Lite, after releasing this it does work as intended since pnpm Make peerDependenciesMeta imply peerDependencies

image

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding merged commit b804aac into main Apr 21, 2023
@ghiscoding ghiscoding deleted the chore/peer-deps-meta branch April 21, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant