Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(version): move all version related methods under version package #456

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat(version): move all version related methods under version package #456

merged 3 commits into from
Jan 24, 2023

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jan 24, 2023 •
edited
Loading

Description

Move all version related methods under version package where it should belong. This PR is more of a cleanup PR in order to eventually make version and publish as optional commands as well in the next major 2.0 version

Motivation and Context

First step to address issue #450 and to eventually make version and publish packages as optional standalone packages, it's better to move all version related methods under the version package.

How Has This Been Tested?

update all necessary unit tests that got affected by the changes

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #456 (934a41d) into main (0b79e4d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   97.38%   97.38%   +0.01%     
==========================================
  Files         152      154       +2     
  Lines        4526     4534       +8     
  Branches     1057     1057              
==========================================
+ Hits         4407     4415       +8     
  Misses        119      119
Impacted Files Coverage Δ
packages/core/src/utils/index.ts 100.00% <ø> (ø)
packages/version/src/conventional-commits/index.ts 100.00% <ø> (ø)
.../src/conventional-commits/make-bump-only-filter.ts 100.00% <ø> (ø)
...rc/conventional-commits/read-existing-changelog.ts 100.00% <ø> (ø)
...sion/src/conventional-commits/recommend-version.ts 100.00% <ø> (ø)
.../src/conventional-commits/writer-opts-transform.ts 100.00% <ø> (ø)
packages/version/src/git-clients/GitLabClient.ts 94.45% <ø> (ø)
packages/version/src/git-clients/gitlab-client.ts 100.00% <ø> (ø)
packages/version/src/git-clients/index.ts 100.00% <ø> (ø)
packages/version/src/utils/temp-write.ts 100.00% <ø> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title chore: move all version command related methods under version package feat(version): move all version related methods under version package Jan 24, 2023
@ghiscoding ghiscoding merged commit 2c0921a into main Jan 24, 2023
@ghiscoding ghiscoding deleted the chore/move-publish-version-common-to-standalone branch January 24, 2023 05:12
@ghiscoding ghiscoding mentioned this pull request Jan 24, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @codecov-commenter