ES6 module import syntax. Fixes #347 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. |
singingwolfboy
approved these changes
Feb 9, 2017
There was a problem hiding this comment.
Thanks so much! I just tested this out locally and it seems to work great, although the JS console does seem to pop a few warnings related to using React in deprecated ways. Still, that can be addressed in a separate pull request.
And yes, adding eslint would be good -- and I didn't know about prettier, but I'll check it out!
| @@ -1,38 +1,35 @@ | |||
| import ErrorDialog from './dialogs/errorDialog'; | |||
| import dialogSystem from './dialogSystem'; | |||
|
|
|||
| function bringUpDialog(error) { | |||
| // we need to import this here due to circular dependencies | |||
There was a problem hiding this comment.
Can you remove this outdated comment?
There was a problem hiding this comment.
Actually, I'll do it post-merge.
nixjdm
pushed a commit
that referenced
this pull request
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
richPromise.jsx.I ran the JS tests locally, all passed. I tried running the Python tests, saw some errors, but they seemed all to originate from dependencies (My knowledge with python and it's tooling is still a bit rough)? I also ran through some manual testing, everything seemed OK, but it would probably be good to get some other hands on it.
One question:
How do the production assets get built when Lektor is deployed to pip / installed from the shell script?
A few recommendations for tasks:
prettierfor JS formatting.