Use hatchling to build distribution #1112
Merged
+351
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
force-pushed
the
refactor.hatchling-build
branch
from
e5e9435 to
8cc7c1f
Compare
3 tasks
dairiki
force-pushed
the
refactor.hatchling-build
branch
from
863d92c to
4915c5d
Compare
This includes a custom build hook to build our frontend js & css
This accomplishes two things: - Ensures that tests pass before publishing - On each workflow run, tests that the packaging works
dairiki
force-pushed
the
refactor.hatchling-build
branch
from
4915c5d to
10e8a1c
Compare
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
* refactor(packaging): use hatchling to build package This includes a custom build hook to build our frontend js & css * refactor(ci): use pypa/gh-action-pypi-publish action * refactor(ci): move publish job to the ci workflow This accomplishes two things: - Ensures that tests pass before publishing - On each workflow run, tests that the packaging works * test(ci): upload built wheel and sdist for examination * refactor(packaging): delete build-dist testenv from tox config * refactor(packaging): remove dist and upload targets from Makefile * docs(README): update the development instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted just the packaging bits out of #1082 and updated them here.
Issue(s) Resolved
Fixes #1081
Related Issues / Links
Supercedes #1082
Description of Changes
Changes include:
setup.cfgtopyproject.toml(PEP 621)publishCI job from thepublish.ymlworkflow into ourci.ymlworkflow.Hatchling's support of build hooks allows us to integrate the building of our front-end JS and CSS into the PEP 517 build process. Among other things, this makes it possible to install a working version of Lektor directly from git. E.g.
will work (assuming the user has a working installation of Node/npm).
Moving the
publishjob to the main CI workflow allows for two improvements: