-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with Boost 1.86.0 #2381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing build issue with boost 1.86.0 and putting up this PR, @dbear496, much appreciated.
The Ledger project somewhat prides itself with maintaining compatibility with older versions of its dependencies.
Please find below a few suggestions that allow ledger to be build with boost 1.86.0 and previous versions. This should also address the CI build failures.
I made my changes compatible with older versions of Boost by using Boost's |
It looks like this PR may need to be rebased onto the current master, since I'm seeing changes here that were merged in by another PR. |
@afh Does this PR look good to you now? |
I'm doing test builds with boost 1.86 and a previous version, while having a closer look at the changes this very moment :) |
While this PR builds with a previous version of boost, it unfortunately fails when building with boost 1.86.0 with:
Does this ring a bell, @dbear496? |
Oh wait, I was on the wrong git branch, that did not have this PRs changes applied. Apologies, let me try again, 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @dbear496, thanks for the improvements and your contribution!! 👍
Happy to report that this PR builds with boost 1.86.0 and previous version (I tested using 1.81.0) and all the tests passed.
A recent update to Boost changed the type of message digests from
int[5]
tochar[20]
. This PR updates the handling of message digests to use the updated type.Fixes #2378.