Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert travis file to actions #203

Merged
merged 15 commits into from
Jun 9, 2023

Conversation

sbimochan
Copy link
Member

resolves #139

  • Please review carefully on echo parts if it would produce the same behavior
  • The secrets needs to be defined in github

wanted to make changes on travis.yml file itself so that diff could be viewed side by side but would create extra PRs and gave syntax error in .travis, later thought it would be a bad file history haha.

@sbimochan
Copy link
Member Author

@mesaugat Travis CI is set to required

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #203 (3b5924b) into master (c065f46) will decrease coverage by 3.29%.
The diff coverage is 26.91%.

❗ Current head 3b5924b differs from pull request most recent head c88495f. Consider uploading reports for the commit c88495f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   38.75%   35.47%   -3.29%     
==========================================
  Files          19       33      +14     
  Lines         369      857     +488     
  Branches       32      115      +83     
==========================================
+ Hits          143      304     +161     
- Misses        224      544     +320     
- Partials        2        9       +7     
Impacted Files Coverage Δ
src/api.ts 0.00% <0.00%> (ø)
src/commands/make-publish.ts 0.00% <0.00%> (ø)
src/commands/make.ts 0.00% <0.00%> (ø)
src/commands/migrate-latest.ts 0.00% <0.00%> (ø)
src/commands/migrate-list.ts 0.00% <0.00%> (ø)
src/commands/migrate-rollback.ts 0.00% <0.00%> (ø)
src/commands/prune.ts 0.00% <0.00%> (ø)
src/commands/synchronize.ts 0.00% <0.00%> (ø)
src/init.ts 0.00% <0.00%> (ø)
src/migration/service/knexMigrator.ts 0.00% <0.00%> (ø)
... and 21 more

... and 1 file with indirect coverage changes

@mesaugat
Copy link
Member

mesaugat commented Jun 7, 2023

@sbimochan Can you use RIBBY_GITHUB_TOKEN as the environment variable instead of GITHUB_TOKEN inside of release.sh file.

I've already included the secrets in GitHub secrets.

sbimochan and others added 3 commits June 8, 2023 12:44
Co-authored-by: Saugat Acharya <mesaugat@gmail.com>
Co-authored-by: Saugat Acharya <mesaugat@gmail.com>
@mesaugat
Copy link
Member

mesaugat commented Jun 9, 2023

@sbimochan Looking good. Will merge, I think there are few places where it still might not work during publish but that we can fix later.

Thanks for sending the PR. We finally don't have to wait 3 years for Travis CI to finish.

@mesaugat mesaugat merged commit ab225cc into leapfrogtechnology:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Travis CI to GitHub Actions
4 participants