Add initial tests for Form module #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @toddy15 I'll check out what you added in a bit. There's already php cos fixer integrated in the main repo. I've just not been able to push it down into all the other modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi @mychidarko,
I've added some minimal tests for the form module. Those could be expanded to check that the default rules actually do what they are supposed to do, I've omitted that for now.
By the way, do you have a code style for leaf, which could be applied automatically? Something like PHP-CS-Fixer with PSR-12, Laravel Pint, prettier or the like?
Regards,
Tobias