@p4veI sure thing! I'll release v2.3 later this week with the newest stella-maris/clock version (@heiglandreas was kind enough to also implement the PSR there) so we have a migration path. Then I'll rebase your PR and ship v2.4 v3.0 👍

Will that break any user-code that depends on this library extending stella-maris/clock? As this is a BC-breaking change IIRC

@heiglandreas imo it's not a BC, but it might depend on the configuration in user projects. I'm using the Clock interface for configuration currently so it's not dependent on the interface it's extending (e.g. psr).

But essentially I'd like to configure the psr interface as an alias to lcobucci/clock implementation and reduce code dependency on this package.

You can already configure lcobucci/clock as implementation of psr/clock.

you could the moment PSR20 was available on packagist.

Re. the BC break:

When someone uses an implementation that so far implemented an interface and drops that interface in a minor version, then the code suddenly breaks after updating to the next minor. At least according to SemVer.

Introducing an interface in a minor: Fine.
Removing an interface in a minor: Less so...

And while I appreciate your effort to reduce dependencies, you can only reduce your direct dependencies. You can do that by using PSR instead if the stella-maris implementation. I encourage everyone to do that. But that should not be extended to your dependencies dependencies...

But that's just my (biased) 0.02 €

@heiglandreas hmm, I'm not sure if I understand.. I guess it's possible with the update @lcobucci mentioned, once stella-maris/clock interface actually implements the psr interface (which as I see now it already does)?

From what I checked when I prepared this PR it was only implementing stella-maris/clock interface which was not extending the psr interface. That's why I did this PR.

I agree with the semver breaks updating though, I'm not really suggesting anything regarding to the version this should be released in, but I feel it's not really necessary to implement an interface of another package that extends the psr interface, I'd just like to see this implementing the psr interface directly.

stella-maris/clock extended psr/clock about 4 hours after that was available on packagist.

And I'm with you that all projects should now use psr/clock as dependency. Sadly we all know that that is not happening always.

Therefore the libraries that are currently extending stella-maris/clock should do so until their next major version to avoid BC-breaks in the projects using them that have not yet updated to psr/clock.

For your use-case: Make lcobucci/clock an alias to psr/clock and everything should work out fine 😁

Merged and released on https://github.com/lcobucci/clock/releases/tag/3.0.0 🎉
Thanks @p4veI