Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement *Copy macros #154

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Implement *Copy macros #154

merged 1 commit into from
Jul 27, 2024

Conversation

jdujava
Copy link
Contributor

@jdujava jdujava commented Jul 26, 2024

This completes the implementation of all command/environment definition macros which are provided by LaTeX kernel and described in https://ctan.org/pkg/usrguide.

Fixes #124.

@clason
Copy link

clason commented Jul 26, 2024

Where do these macros come from? It's obviously completely infeasible to add every command and environment that some package provides (and every package is indispensable to someone...); there should be some objective line drawn and documented.

(Since these are provided by the LaTeX kernel, they'd probably make the cut; but a PR should explicitly make the case both in the PR description and(!) in the commit description. A good description is a necessary part of a good PR; uncommented contributions make maintainers' lives unnecessarily hard...)

@jdujava
Copy link
Contributor Author

jdujava commented Jul 26, 2024

Agreed, sorry for that. Will add proper description soon.

@jdujava
Copy link
Contributor Author

jdujava commented Jul 26, 2024

Don't know why CI/Check grammar size fails :/.

@pfoerster
Copy link
Member

Don't know why CI/Check grammar size fails :/.

Should be fixed now, it was using the wrong branch name ^^

@jdujava Can you rebase your PRs, please?

This completes the implementation of all command/environment
definition macros which are provided by LaTeX kernel and
described in https://ctan.org/pkg/usrguide.

Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
@pfoerster pfoerster merged commit f23cf64 into latex-lsp:master Jul 27, 2024
5 checks passed
@jdujava jdujava deleted the copy-macros branch July 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Copy" macros for cmds/environments
3 participants