Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support definition commands from xparse #148

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

jdujava
Copy link
Contributor

@jdujava jdujava commented Jul 19, 2024

Additionally, handle command definition without curly braces around the defined command name.

Fixes #129

@jdujava jdujava force-pushed the fix-new-document-command branch from ffe9398 to 9f26104 Compare July 19, 2024 21:06
@jdujava
Copy link
Contributor Author

jdujava commented Jul 19, 2024

Should I also update src/grammar.json and src/node-types.json?

@clason
Copy link

clason commented Jul 19, 2024

Should I also update src/grammar.json and src/node-types.json?

Yes.

@jdujava jdujava force-pushed the fix-new-document-command branch from 9f26104 to 140044e Compare July 20, 2024 17:11
@jdujava
Copy link
Contributor Author

jdujava commented Jul 20, 2024

Done.

grammar.js Outdated Show resolved Hide resolved
Additionally, handle command definition without curly braces
around the defined command name.

Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
@jdujava jdujava force-pushed the fix-new-document-command branch from 140044e to 7a20b13 Compare July 20, 2024 23:12
@pfoerster pfoerster merged commit 55ef65a into latex-lsp:master Jul 21, 2024
4 checks passed
@jdujava jdujava deleted the fix-new-document-command branch July 21, 2024 06:59
jdujava added a commit to jdujava/tree-sitter-latex that referenced this pull request Jul 21, 2024
Additionally, handle command definition without curly braces
around the defined command name.

Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parsing of new_command_definition
3 participants