Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\newcommand in class files messes up hover equation preview #228

Closed
ghost opened this issue May 10, 2020 · 2 comments
Closed

\newcommand in class files messes up hover equation preview #228

ghost opened this issue May 10, 2020 · 2 comments
Assignees
@pfoerster
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented May 10, 2020 •
edited by ghost
Loading

There seems to be something odd about the handling of \newcommand in class files: sometimes the contents get shown in the generated hover previews, for example \newcommand{\myclass@foo}{bar} gets rendered in the beginning of the hover preview as foobar. Changing the \newcommand to a \def avoids the rendering, but clearly the \newcommand shouldn't be rendered.

(This in the VSCode version.)
@pfoerster pfoerster self-assigned this May 10, 2020
@pfoerster pfoerster added the bug Something isn't working label May 10, 2020
@pfoerster
Copy link
Member

Thanks for the report. This should be fixed with texlab 2.2.0.

@ghost
Copy link
Author

ghost commented May 27, 2020

Seems to work 👍, however after a symlink workaround to the failed server download reported in latex-lsp/texlab-vscode#255.

@ghost ghost mentioned this issue May 27, 2020
Closed
@ghost ghost closed this as completed May 27, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfoerster pfoerster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pfoerster