Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP CS Fixer & Prettier #520

Merged
merged 12 commits into from
May 2, 2020
Merged

PHP CS Fixer & Prettier #520

merged 12 commits into from
May 2, 2020

Conversation

driesvints
Copy link
Member

No description provided.

@driesvints driesvints requested a review from joedixon May 2, 2020 13:07
joedixon
joedixon reviewed May 2, 2020
View reviewed changes
Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only feedback I have is some potential additional cs fixer rules.

.php_cs.dist Show resolved Hide resolved
joedixon
joedixon approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@joedixon joedixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@driesvints driesvints merged commit d898cd5 into master May 2, 2020
@driesvints driesvints deleted the phpcs branch May 2, 2020 16:04
@bramus
Copy link

bramus commented May 6, 2020

Is there a specific reason to have one job extract the branch name using echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})" and have the other job use github.head_ref?

@driesvints
Copy link
Member Author

@bramus good spot actually. I just copied the workflows from the article I read 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joedixon joedixon joedixon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @bramus @joedixon