Format the first letter of drivers to lowercase
#6413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I offered to unify the PHPDoc comments in #6305, but this was rejected. |
|
@TENIOS |
I don't write English well and it's hard for me to describe the significance of this idea, so I'm thinking because of this. |
|
@TENIOS |
|
Would rather just make them uppercase. |
|
Congratulations, @maru0914! I hope you can realize what I couldn't. |
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Jun 17, 2024
duncanmcclean
added a commit
to statamic/statamic
that referenced
this pull request
Jun 17, 2024
* Fix PHPUnit constraint See: laravel/laravel#6389 * add resend See laravel/laravel@4b15887 * resend See laravel/laravel@e7cc577 * Updated SMTP mail config to use a valid EHLO domain See laravel/laravel#6402 * Format the first letter of drivers to lowercase See laravel/laravel#6413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the word
Driversappears inconsistently in the config files' PHPDoc, sometimes as camel case and sometimes in lowercase.For consistency, I changed all instances of
Driverstodrivers.Other occurrences of lowercase
driverscan be found here:laravel/config/app.php
Line 117 in b6d5557
laravel/config/cache.php
Line 29 in b6d5557
laravel/config/queue.php
Line 102 in b6d5557