Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Shall we prepend phpdoc before softDeletes trait? #1593

Closed
@xiaohuilam

Description

I mean patch src/Illuminate/Database/Eloquent/SoftDeletes.php

<?php

namespace Illuminate\Database\Eloquent;

trait SoftDeletes
{
    //....
}

to

<?php

namespace Illuminate\Database\Eloquent;

/**
 * @method static self|\Illuminate\Database\Eloquent\Builder onlyTrashed()
 * @method static self|\Illuminate\Database\Eloquent\Builder withTrashed()
 * @method static self|\Illuminate\Database\Eloquent\Builder withoutTrashed()
 */
trait SoftDeletes 
{ 
    //...
}

so that we can define some annotations to treat an object is a softDeletes model, which contains those methods.

image

Should we?

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions